[master] ToSlicePtr: improve speed

samber · Jun 14, 2024 · 2f28273 · 2f28273
1 parent 71d8341
commit 2f28273
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/slice_benchmark_test.go b/slice_benchmark_test.go
@@ -171,3 +171,10 @@ func BenchmarkReplace(b *testing.B) {
 		})
 	}
 }
+
+func BenchmarkToSlicePtr(b *testing.B) {
+	preallocated := make([]int, 100000)
+	for i := 0; i < b.N; i++ {
+		_ = ToSlicePtr(preallocated)
+	}
+}
diff --git a/type_manipulation.go b/type_manipulation.go
@@ -45,9 +45,12 @@ func FromPtrOr[T any](x *T, fallback T) T {
 
 // ToSlicePtr returns a slice of pointer copy of value.
 func ToSlicePtr[T any](collection []T) []*T {
-	return Map(collection, func(x T, _ int) *T {
-		return &x
-	})
+	result := make([]*T, len(collection))
+
+	for i := range collection {
+		result[i] = &collection[i]
+	}
+	return result
 }
 
 // ToAnySlice returns a slice with all elements mapped to `any` type