Fixed improper cache configuration. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmoy12c
commented
Sep 7, 2023
Comment on lines
+34
to
+35
| "cache-manager": "^3.6.0", | ||
| "cache-manager-redis-store": "^2.0.0", |
There was a problem hiding this comment.
This was downgraded due to compatibility issues with redis store.
Look here.
ChakshuGautam
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache that was being used, forgot client IDs when the number of requests exceeded a certain threshold. Also, the initial implementation uses an in-memory cache which would be problematic while scaling up the service since the client id data would only be available to one of the instances, and if the response from outbound is received by another instance, the client id would be null.