plasma-infra: Настроить tree shaking с учетом работы с css #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1554/ |
|
Documentation preview deployed! website:https://plasma.sberdevices.ru/pr/pr-1554/ |
Yakutoc
force-pushed
the
fix-tree-shaking-css
branch
from
774f548
to
bdd7a01
Compare
Yakutoc
changed the title
Yakutoc
requested review from
Yeti-or,
neretin-trike,
TitanKuzmich and
shuga2704
as code owners
github-actions
bot
requested review from
iljs and
TitanKuzmich
and removed request for
Yeti-or,
neretin-trike,
TitanKuzmich and
shuga2704
iljs
approved these changes
Nov 12, 2024
denivladislav
approved these changes
Nov 12, 2024
TitanKuzmich
approved these changes
Nov 12, 2024
Yeti-or
approved these changes
Nov 12, 2024
| @@ -133,5 +133,5 @@ | |||
| "Vasiliy Loginevskiy", | |||
| "Anton Vinogradov" | |||
There was a problem hiding this comment.
может нам генерировать списки из https://github.com/salute-developers/plasma/blob/dev/CODEOWNERS#L5
ну или https://github.com/salute-developers/plasma/blob/dev/.github/teammates.json ?
There was a problem hiding this comment.
@Yeti-or Заведу задачу на это. Пока не знаю.
Yakutoc
force-pushed
the
fix-tree-shaking-css
branch
from
bdd7a01
to
4a4844f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/why changed
Для пакетов
sdds-{serv,insol}включили{ "sideEffects": ["*.css"] }иначе при конечной сборке на стороне пользователя не будут работа стили.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: