Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-*,sdds-*): Icon only badge #1546

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat(plasma-*,sdds-*): Icon only badge #1546

wants to merge 4 commits into from

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Nov 7, 2024 •
edited by Salute-Eva
Loading

Badge

  • добавлен surfaceClear токен для clear варианта Badge
  • добавлены padding для clear варианта Badge
  • реализован вариант с одной иконкой, без текста
  • добавлена возможность передать пользовательский цвет для текста и фона Badge
  • написаны тесты

What/why changed

Badge приведен в соответствие с макетами.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1546/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1546/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1546/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1546/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1546/new-hope-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1546/ui-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1546/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1546/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1546/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1546/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1546/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1546/sdds-serv-storybook/

@TitanKuzmich TitanKuzmich marked this pull request as ready for review November 13, 2024 09:38
@github-actions github-actions bot requested review from denivladislav and shuga2704 and removed request for Yeti-or, Yakutoc, neretin-trike and shuga2704 November 13, 2024 09:38
denivladislav
denivladislav approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@denivladislav denivladislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Yakutoc
Yakutoc reviewed Nov 14, 2024
View reviewed changes
packages/plasma-new-hope/src/components/Badge/Badge.types.ts
*/
contentLeft?: ReactNode;
customColor?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TitanKuzmich В документации отразим новые возможности?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yakutoc Yakutoc Yakutoc left review comments

@simashova simashova simashova approved these changes

@denivladislav denivladislav denivladislav approved these changes

@shuga2704 shuga2704 Awaiting requested review from shuga2704 shuga2704 is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @Yakutoc @denivladislav @simashova