Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-new-hope, sdds-cs: fix Tabs and Breadcrumbs #1532

Merged
merged 4 commits into from
Nov 12, 2024
Merged

plasma-new-hope, sdds-cs: fix Tabs and Breadcrumbs #1532

merged 4 commits into from
Nov 12, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Nov 1, 2024 •
edited by Salute-Eva
Loading

Tabs

  • для sdds-cs исправлены значения токенов itemSelectedDividerColor и itemSelectedDividerColorHover
  • для sdds-dfa исправлены токены для состояния disabled
  • исправлены argTypes в сторибуках

Breadcrumbs

  • исправлен курсор при наведении на текущий Breadcrumb
  • исправлены токены для hover и active состояний у Breadcrumb

What/why changed

Tabs before

tabsBefore.mov

Tabs after

tabsAfter.mov

Breadcrumbs before

breadcrumbsBefore.mov

Breadcrumbs after

breadcrumbsAfter.mov
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@denivladislav denivladislav added bugs Something isn't working plasma-components labels Nov 1, 2024
@denivladislav denivladislav self-assigned this Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1532/

@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from a68636a to c60abae Compare November 1, 2024 12:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1532/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1532/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1532/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1532/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1532/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1532/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1532/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1532/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1532/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1532/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1532/ui-storybook/

@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from c60abae to 9b19fae Compare November 1, 2024 13:22
@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from 9b19fae to 506dada Compare November 1, 2024 14:33
@denivladislav denivladislav marked this pull request as ready for review November 7, 2024 09:11
@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from f3f09d8 to 8525f7a Compare November 11, 2024 14:01
@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from 8525f7a to 44b872e Compare November 12, 2024 09:02
@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from 44b872e to e918c97 Compare November 12, 2024 09:43
@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from e918c97 to ab33e13 Compare November 12, 2024 13:15
@denivladislav denivladislav force-pushed the PLASMA-3796/fix-tabs-breadcrumbs-configs branch from ab33e13 to 9bca419 Compare November 12, 2024 14:20
@denivladislav denivladislav added this pull request to the merge queue Nov 12, 2024
Merged via the queue into dev with commit cf2b4b9 Nov 12, 2024
29 checks passed
@denivladislav denivladislav deleted the PLASMA-3796/fix-tabs-breadcrumbs-configs branch November 12, 2024 15:30
@Salute-Eva Salute-Eva mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizasok luizasok luizasok approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@denivladislav denivladislav

Labels
bugs Something isn't working plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denivladislav @vadim-kudr @TitanKuzmich @luizasok