Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Badge & Tabs truncate props #1500

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat: add Badge & Tabs truncate props #1500

merged 1 commit into from
Nov 8, 2024

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Oct 22, 2024 •
edited by TitanKuzmich
Loading

Badge, Tabs

  • реализована возможность обрезания текста по максимальной ширине

What/why changed

Добавлены свойства maxWidth и maxItemWidth, включающее text-overflow: ellipsis для Badge и TabItem

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1500/

@Yakutoc Yakutoc marked this pull request as draft October 22, 2024 08:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1500/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1500/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1500/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1500/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1500/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1500/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1500/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1500/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1500/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1500/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1500/ui-storybook/

@vadim-kudr vadim-kudr self-assigned this Oct 28, 2024
@vadim-kudr vadim-kudr marked this pull request as ready for review October 29, 2024 10:03
@github-actions github-actions bot removed the request for review from Yeti-or October 29, 2024 10:05
@TitanKuzmich
Copy link
Contributor

Добавь пожалуйста тест на truncate. И сейчас почему-то обновленные тесты только для plasma-web

@vadim-kudr vadim-kudr added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit 33e698f Nov 8, 2024
31 checks passed
@vadim-kudr vadim-kudr deleted the PLASMA-3627 branch November 8, 2024 08:00
@Salute-Eva Salute-Eva mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@simashova simashova Awaiting requested review from simashova

Assignees

@vadim-kudr vadim-kudr

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vadim-kudr @TitanKuzmich @shuga2704