Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-icons: handle all icons size [Android] #1259

Merged
merged 1 commit into from
Jun 24, 2024
Merged

plasma-icons: handle all icons size [Android] #1259

merged 1 commit into from
Jun 24, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Jun 19, 2024 •
edited by Salute-Eva
Loading

Android

  • добавлены .xml иконки для всех имеющихся размеров: 16, 24, 36

After

Screenshot 2024-06-19 at 13 44 22 Screenshot 2024-06-19 at 13 46 09

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc self-assigned this Jun 19, 2024
@Yakutoc Yakutoc changed the title feat(plasma-icons): handle all icons size [Android] plasma-icons: handle all icons size [Android] Jun 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1259/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024 •
edited
Loading

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1259/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1259/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1259/b2c-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1259/ui-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1259/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1259/sdds-serv-storybook/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1259/caldera-online-storybook/

@Yakutoc Yakutoc force-pushed the feat-android-handle-all-size branch from ef09651 to 5a90f47 Compare June 21, 2024 10:18
@Yakutoc Yakutoc marked this pull request as ready for review June 21, 2024 10:18
@denivladislav denivladislav self-requested a review June 21, 2024 10:27
@Yakutoc Yakutoc force-pushed the feat-android-handle-all-size branch from 5a90f47 to 50b4ce1 Compare June 21, 2024 12:53
@Yakutoc Yakutoc added this pull request to the merge queue Jun 24, 2024
Merged via the queue into dev with commit 5adb0be Jun 24, 2024
30 checks passed
@Yakutoc Yakutoc deleted the feat-android-handle-all-size branch June 24, 2024 06:29
@Salute-Eva Salute-Eva mentioned this pull request Jun 26, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or left review comments

@denivladislav denivladislav denivladislav approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

Assignees

@Yakutoc Yakutoc

Labels
plasma-icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yakutoc @Yeti-or @neretin-trike @denivladislav