plasma-icons: Handle all sizes [React] #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1258/ |
|
Documentation preview deployed! website:https://plasma.sberdevices.ru/pr/pr-1258/ |
Yakutoc
force-pushed
the
feat-handle-icon-size
branch
from
f26b4cb
to
d9464cd
Compare
Yakutoc
commented
Jun 19, 2024
Yakutoc
requested review from
Yeti-or,
neretin-trike,
TitanKuzmich and
shuga2704
as code owners
Yakutoc
changed the title
Yakutoc
requested review from
denivladislav
and removed request for
TitanKuzmich and
shuga2704
denivladislav
approved these changes
Jun 19, 2024
neretin-trike
approved these changes
Jun 19, 2024
⚡ Component performance testingResult: 🟢 OK |
⚡ Component performance testingResult: 🟢 OK |
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React
IconDoneBefore/After
New-hope
colorвIconRoot(теперьvar(--text-primary))var(--text-primary)What/why changed
Ранее система координат и область просмотра у всех иконок была одинаковая -
viewBox="0 0 24 24"Теперь под каждый размер есть свой иконка со своим viewBox.
Пример с canary версией
IconDoneТак как у иконок теперь есть физический размер (viewBox) 16х16 часть snapshots нужно было переснять.
Bundle before
Bundle after
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: