Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope): add default selected segment #1252

Merged
merged 7 commits into from
Jun 26, 2024
Merged

feat(plasma-new-hope): add default selected segment #1252

merged 7 commits into from
Jun 26, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jun 14, 2024 •
edited by Salute-Eva
Loading

Segment

  • добавлена возможность задать выбранные по умолчанию сегменты
  • добавлен тест на выбранные значения
  • добавлено пояснение в документации

What/why changed

В сегменте не было возможности указать выбранные элементы по умолчанию.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1252/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1252/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1252/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1252/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1252/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1252/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1252/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1252/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1252/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2971/default-selected-segment branch from a32806d to 143d04a Compare June 25, 2024 14:01
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2971/default-selected-segment branch from 143d04a to bb59140 Compare June 26, 2024 09:53
@Yakutoc Yakutoc removed request for Yakutoc and iljs June 26, 2024 10:13
@TitanKuzmich TitanKuzmich force-pushed the plasma-2971/default-selected-segment branch from ea6814e to 13a7952 Compare June 26, 2024 10:26
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@TitanKuzmich TitanKuzmich force-pushed the plasma-2971/default-selected-segment branch from 13a7952 to e544481 Compare June 26, 2024 10:41
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Jun 26, 2024
Merged via the queue into dev with commit b6855e9 Jun 26, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2971/default-selected-segment branch June 26, 2024 11:33
@Salute-Eva Salute-Eva mentioned this pull request Jun 26, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @Yeti-or @neretin-trike