Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope): tooltip old api fallback #1140

Merged
merged 5 commits into from
Mar 26, 2024
Merged

feat(plasma-new-hope): tooltip old api fallback #1140

merged 5 commits into from
Mar 26, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Mar 21, 2024 •
edited by Salute-Eva
Loading

Tooltip

  • добавлены фолбэки на следующие свойства: isVisible, arrow, animated

What/why changed

При рефакторинге тултипа потерялись некоторые пропсы из-за чего пропала обратная совместимость.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Mar 21, 2024
@TitanKuzmich TitanKuzmich force-pushed the plasma-2665/tooltip-old-api-fallback branch from 72737fb to a48c5f2 Compare March 21, 2024 11:13
@TitanKuzmich TitanKuzmich marked this pull request as ready for review March 21, 2024 11:14
@TitanKuzmich TitanKuzmich requested review from shuga2704 and removed request for Yeti-or, Yakutoc and kayman233 March 21, 2024 11:14
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1140/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1140/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1140/caldera-online-storybook/
caldera storybook: https://plasma.sberdevices.ru/pr/pr-1140/caldera-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1140/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1140/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1140/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1140/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1140/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

neretin-trike
neretin-trike reviewed Mar 21, 2024
View reviewed changes
packages/sdds-serv/src/components/Tooltip/Tooltip.config.ts
view: {
default: css`
${tooltipTokens.backgroundColor}: var(--surface-solid-card);
${tooltipTokens.boxShadow}: 0px 4px 12px 0px rgba(0, 0, 0, 0.16),0px 1px 4px 0px rgba(0, 0, 0, 0.08);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай TODO добавим ссылкой на этот issue #1131

@TitanKuzmich TitanKuzmich force-pushed the plasma-2665/tooltip-old-api-fallback branch from a48c5f2 to 2e2c7f3 Compare March 21, 2024 12:40
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@shuga2704
Copy link
Contributor

Раз уж мы дошли до рефакторинга тултипа, может еще и это профиксим? #1121

@TitanKuzmich TitanKuzmich force-pushed the plasma-2665/tooltip-old-api-fallback branch from 2e2c7f3 to 08da802 Compare March 25, 2024 08:16
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2665/tooltip-old-api-fallback branch from 08da802 to 3f82df3 Compare March 26, 2024 09:49
@TitanKuzmich TitanKuzmich added this pull request to the merge queue Mar 26, 2024
Merged via the queue into dev with commit 404cc5b Mar 26, 2024
28 of 29 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2665/tooltip-old-api-fallback branch March 26, 2024 10:55
@Salute-Eva Salute-Eva mentioned this pull request Mar 27, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @shuga2704 @neretin-trike