Add new streaks to players profile page #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } = this.props | ||
|
|
||
| return ( | ||
| <Box Display="inline-block" Padding="20px" Margin="20px 0"> | ||
| <Title>{name}</Title> | ||
| <Subtitle>Elo rating: {rating}</Subtitle> | ||
| <Subtitle>ELO rating: {rating}</Subtitle> |
There was a problem hiding this comment.
I think it's someone's name, it was spelled 'Elo' on purpose 😄
There was a problem hiding this comment.
Oops, ok, I'll fix that.
|
@zbrcz would you like to rebase this PR so we can merge it? or do we close it? |
|
@novellizator I originally made these changes last September and the PR had been ignored until February when you asked me to re-create it and again it's been ignored since... So I don't feel like fixing conflicts that could've been avoided if the PRs received proper attention. If you want to close it, close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated #69 so that it's deployed on Heroku.
Added "needs styling" because it needs some frontend work to put the statistics on two or three lines. I guess let's find a UI dev when the review is done.