Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-175: Fix slackbot declaration #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

gh-175: Fix slackbot declaration #176

wants to merge 2 commits into from

Conversation

littlewhywhat
Copy link
Contributor

@littlewhywhat littlewhywhat commented Sep 13, 2020 •
edited
Loading

  • Using export = Slackbot instead of export default
  • enable esModuleInterop
  • have to import similarly express

and things start to magically work 🤷‍♂️

sorry that I was so slow on fixing it

@littlewhywhat littlewhywhat self-assigned this Sep 13, 2020
@jkotrlik jkotrlik temporarily deployed to foosball-dev-pr-176 September 13, 2020 10:23 Inactive
@littlewhywhat
Copy link
Contributor Author

a bit worried about other modules that are imported as import * as but e2e passes and they test now basic functions... so I guess it needed to be fixed only for moment and express. What do you think? @stetizu1

@jkotrlik jkotrlik temporarily deployed to foosball-pr-176 February 11, 2022 15:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novellizator novellizator Awaiting requested review from novellizator

@petrk-salsita petrk-salsita Awaiting requested review from petrk-salsita

Assignees

@littlewhywhat littlewhywhat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littlewhywhat @novellizator @jkotrlik