Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send scores #165

Open
wants to merge 2 commits into
base: add-scores-in-matches
Choose a base branch
from
Open

Send scores #165

wants to merge 2 commits into from

Conversation

littlewhywhat
Copy link
Contributor

@littlewhywhat littlewhywhat commented May 29, 2020 •
edited
Loading

  • send scores 1:0 or 0:1 instead of boolean team1Won
  • add e2e tests to check that match is recorded in match lists - both component in dashboard and the page

@littlewhywhat
Send scores
59b08b2 
Signed-off-by: Roman Vaivod <[email protected]>
@jkotrlik jkotrlik temporarily deployed to foosball-dev-pr-165 May 29, 2020 21:09 Inactive
@littlewhywhat littlewhywhat marked this pull request as ready for review June 6, 2020 07:18
@littlewhywhat littlewhywhat self-assigned this Jun 6, 2020
@jkotrlik jkotrlik temporarily deployed to foosball-dev-pr-165 June 15, 2020 13:29 Inactive
@novellizator novellizator marked this pull request as draft July 3, 2020 12:17
@littlewhywhat littlewhywhat marked this pull request as ready for review July 3, 2020 13:55
@littlewhywhat
Copy link
Contributor Author

looks like it's ready - there is even an e2e test to be sure that things work :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novellizator novellizator Awaiting requested review from novellizator

@petrk-salsita petrk-salsita Awaiting requested review from petrk-salsita

Assignees

@littlewhywhat littlewhywhat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littlewhywhat @jkotrlik