Prepare v5.1.0-rc.0 #481
Closed
Prepare v5.1.0-rc.0 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
reviewed
Jan 8, 2025
| @@ -52,8 +52,7 @@ const safeToStringImpl = (val: unknown, seenArrays = new WeakSet()): string => { | |||
| return Array.isArray(val) | |||
| ? // Arrays have a weird custom toString that we need to replicate | |||
| safeArrayToString(val, seenArrays) | |||
| : // eslint-disable-next-line @typescript-eslint/no-base-to-string | |||
| String(val) | |||
| : String(val) | |||
There was a problem hiding this comment.
Yeah, that confused me too. I think the version of eslint I had installed locally was out of date. Running the steps locally before doing an npm install caused npm run _eslint:fix to remove that line. Running the steps locally after doing an npm install leaves that line in place.
Going to close and recreate this PR from scratch to confirm.
|
Something may have been off with my local setup. Closing this PR and redoing the release steps to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing out the new release process with this prerelease version.