Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new rule to warn that importing and using Apex module may not work properly on mobile when offline. #3

Merged
merged 9 commits into from
May 21, 2024

Conversation

sfdctaka
Copy link
Contributor

Data from Apex is read only, if it was already cached, but not editable on mobile when offline.
https://developer.salesforce.com/docs/atlas.en-us.mobile_offline.meta/mobile_offline/apex.htm

This new eslint rule warns users of that.

Documentation for the rule will come later when it is ready.

@ben-zhang-at-salesforce
Copy link
Contributor

very good job! only find very minor thing.

@haifeng-li-at-salesforce
Copy link
Contributor

Good job! The squiggly line is verified.
image

Copy link
Contributor

@haifeng-li-at-salesforce haifeng-li-at-salesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code and well-done job!

Copy link
Contributor

@ben-zhang-at-salesforce ben-zhang-at-salesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sfdctaka sfdctaka merged commit d8eb92d into main May 21, 2024
17 checks passed
@sfdctaka sfdctaka deleted the apex branch May 21, 2024 22:06
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants