Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-15246641 : fix for Disappearing tooltip button content #3171

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bdewangan
Copy link
Contributor

@bdewangan bdewangan commented Jan 16, 2025

Fixes #

Additional description


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@xulingzhihou
Copy link
Contributor

@bdewangan could you add a description to summarize your fix. A screenshot or recording could also be helpful

@xulingzhihou
Copy link
Contributor

Based on the logic you implemented, it seems like you are trying to do here is: when the mouse is outside of the tooltip element or if it is not in hover state, we close the tooltip. I think a better way to address it is to making. tooltips persistent after triggering until explicitly dismissed. With this, we also need to provide a clear way to dismiss the tooltip (ESC key or click outside, or has a close icon)

@bdewangan
Copy link
Contributor Author

we have made changes to make it stay when hovered over the tooltip
It get dismissed after move moved outside i have attached recording
https://github.com/user-attachments/assets/649a068f-88a3-45e8-8660-f6caae0f9793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants