Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for buildifier auto-formating on save #123

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

lonhutt
Copy link
Contributor

@lonhutt lonhutt commented Sep 4, 2024

Added the following:

  • starlark syntax and language config file (needed for language detection)
  • added buildifier format on save feature; this is gated behind a couple of flags
    • editor.formatOnSave
    • bazel.buildifier.enable
  • both flags must be true to enable this feature (follows best practices laid out here)

Copy link

github-actions bot commented Sep 4, 2024

Test Results

 2 files  ±0   2 suites  ±0   23h 17m 26s ⏱️ - 12h 4m 50s
 7 tests ±0   7 ✅ ±0  0 💤 ±0  0 ❌ ±0 
14 runs  ±0  14 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0d8c0ff. ± Comparison against base commit 5e22ac9.

♻️ This comment has been updated with latest results.

src/buildifier.ts Outdated Show resolved Hide resolved
src/buildifier.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@lonhutt lonhutt merged commit 4f12bc1 into main Sep 9, 2024
7 checks passed
@lonhutt lonhutt deleted the add_buildifier_support branch September 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants