add client facing tag to input queue sampler

salesforce · Feb 10, 2024 · 5f281d3 · 5f281d3
1 parent 7fd5f3a
commit 5f281d3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.../timbermill-local/src/main/java/com/datorama/oss/timbermill/common/ElasticsearchUtil.java b/.../timbermill-local/src/main/java/com/datorama/oss/timbermill/common/ElasticsearchUtil.java
@@ -14,7 +14,7 @@
 import java.util.stream.Collectors;
 
 import static com.datorama.oss.timbermill.TaskIndexer.logErrorInEventsMap;
-import static com.datorama.oss.timbermill.pipe.LocalOutputPipe.tryReportClientFacingInputQueueMetric;
+import static com.datorama.oss.timbermill.pipe.LocalOutputPipe.tryReportInputQueueMetricWithTag;
 
 public class ElasticsearchUtil {
 	public static final String CLIENT = "client";
@@ -324,7 +324,7 @@ public static void drainAndIndex(BlockingQueue<Event> eventsQueue, TaskIndexer t
 				eventsQueue.drainTo(unfilteredEvents, maxElement);
 				Collection<Event> events = filterEvents(unfilteredEvents, skipEventsAtDrainFlag, notToSkipRegex);
 				events.forEach(e -> {
-					if(!tryReportClientFacingInputQueueMetric(e, false)) {
+					if(!tryReportInputQueueMetricWithTag(e, false)) {
 						KamonConstants.MESSAGES_IN_INPUT_QUEUE_RANGE_SAMPLER.withoutTags().decrement();
 					}
 				});

diff --git a/...java/timbermill-local/src/main/java/com/datorama/oss/timbermill/pipe/LocalOutputPipe.java b/...java/timbermill-local/src/main/java/com/datorama/oss/timbermill/pipe/LocalOutputPipe.java
@@ -123,14 +123,14 @@ public static void doPushEventToQueues(PersistenceHandler persistenceHandler, Bl
                 KamonConstants.MESSAGES_IN_OVERFLOWED_QUEUE_RANGE_SAMPLER.withoutTags().increment();
             }
         } else {
-            if(!tryReportClientFacingInputQueueMetric(event, true)) {
+            if(!tryReportInputQueueMetricWithTag(event, true)) {
                 KamonConstants.MESSAGES_IN_INPUT_QUEUE_RANGE_SAMPLER.withoutTags().increment();
             }
         }
     }
 
 
-    public static boolean tryReportClientFacingInputQueueMetric(Event event, boolean isIncrement) {
+    public static boolean tryReportInputQueueMetricWithTag(Event event, boolean isIncrement) {
         LOG.info("about to tryReportClientFacingInputQueueMetric for event name:{}", event.getName());
         boolean success = false;
         //todo: remove