Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10184 - Timezone not set on silent install #10185

Merged

Conversation

jack7anderson7
Copy link
Contributor

Fix #10184

Description

Fix timezone not being set when running through silent install/ cli install

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@clemente-raposo clemente-raposo added Status: Passed Testing Status: Passed Code Review Mark issue has passed code review reviewed labels Sep 13, 2023
@jack7anderson7 jack7anderson7 merged commit d3e6fe4 into salesagility:hotfix Sep 19, 2023
1 check passed
@ps-amaureder
Copy link

ps-amaureder commented Aug 6, 2024

This generates a problem as soon as the Users save() method is called, as it always sets the timezone to 'UTC'.
This should get fixed
I created an Issue: #10494

@chris001
Copy link
Contributor

chris001 commented Aug 9, 2024

            } else {
                $this->setPreference('timezone', 'UTC', 0, 'global');
            }

Possible solutions:

  1. If in CLI install mode, and getPreference('timezone') is empty or unset, then setPreference('timezone') to UTC.
  2. If getPreference('timezone') is empty or unset (this means in CLI install mode), then setPreference('timezone') to UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response is empty in Launch Wizard Campaign
5 participants