Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy placement v3 fix #11

Merged

Conversation

zly2006
Copy link

@zly2006 zly2006 commented Jul 8, 2024

No description provided.

@zly2006 zly2006 changed the title fix: invalid block states Easy placement v3 fix Jul 8, 2024
@sakura-ryoko
Copy link
Owner

I tested the Rails, Leaves, etc under Litematica, and the Crafter / Dropper rotations under Tweakeroo, and noticed that this code "fixes" the invalid button placements.

Any more tests that you think this needs? I believe this is more of a "polishing" type of fix.

@zly2006
Copy link
Author

zly2006 commented Jul 9, 2024

Any more tests that you think this needs? I believe this is more of a "polishing" type of fix.

I have no idea of that... I have deployed this fix to my server (I treat the invalid block states as an important issue) and hope the players can find something not yet fixed.

@zly2006
Copy link
Author

zly2006 commented Jul 9, 2024

And currently PROPERTY_VALIDATORS is not really used. If there is eventually no usage of it we should clean it up.

@sakura-ryoko
Copy link
Owner

sakura-ryoko commented Jul 9, 2024

So basically this fix is just removing unused/buggy Whitelisted Properties ?

@zly2006
Copy link
Author

zly2006 commented Jul 9, 2024

So basically this fix is just removing unused/buggy Whitelisted Properties ?

also check state.canPlaceAt so floating buttons wont be placed.

@sakura-ryoko
Copy link
Owner

sakura-ryoko commented Jul 9, 2024

I put out a release for Litematica to fix another bug, and included the existing code here in the release, for now; so you can use it for testing with sakura.15 of it

@zly2006 zly2006 marked this pull request as ready for review July 9, 2024 10:20
@zly2006
Copy link
Author

zly2006 commented Jul 9, 2024

I think they can be merged now

@sakura-ryoko sakura-ryoko merged commit 8630972 into sakura-ryoko:pre-rewrite/fabric/1.21 Jul 9, 2024
2 checks passed
@zly2006 zly2006 deleted the block-state branch July 9, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants