SAK-50849 Accessibility WCAG 1.4.3 Color Contrast on Gateway Welcome Page #13171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottenhoff
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Sakai has a light and dark theme, so this needs to work for both. Additionally, colors are meant to be easily tuned for the institution. There are many --vars representing colors like --sakai-text-color-2 that would need to be changed instead of a hard-coded color addition
|
Thank you for the feedback, I will work on this and send in the new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the color contrast ratio to meet the WCAG 1.4.3 standard.