Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-37749 Lessonbuilder accessibility collapsible sections cannot be opened with keyboard #12965

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SAK-37749 Lessonbuilder accessibility collapsible sections cannot be opened with keyboard #12965

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33c428e
SAK-37749 Lessonbuilder accessibility collapsible sections cannot be …
i-a-m-s-k Oct 15, 2024
f379f83
SAK-37749 Lessonbuilder accessibility collapsible sections cannot be …
i-a-m-s-k Nov 11, 2024
f8b0718
Merge branch 'master' into SAK-37749
ottenhoff Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lessonbuilder/tool/src/webapp/templates/ShowPage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2384,11 +2384,12 @@ <h5 class="modal-title" id="titleModalLabel" rsf:id="msg=simplepage.title">simpl
<h3 rsf:id="msg=simplepage.maincontent" class="lb-offscreen" id="maintablelabel"></h3>
<!-- WARNING: javascript for add-break-section adds section, ul, li, and sectionedit markup, so if you change here, keep it in sync -->
<div rsf:id="sectionWrapper:">
<h3 rsf:id="sectionHeader" id="sectionHeader" class="sectionHeader">
<a rsf:id="sectionHeader" id="sectionHeader" class="sectionHeader d-block text-decoration-none h3" href="#collapsibleContent" tabindex="0" data-bs-toggle="collapse" aria-expanded="true" aria-controls="collapsibleContent">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need d-block ?

<span aria-hidden="true" class="collapseIcon fa-caret-down"></span>
<span rsf:id="sectionHeaderText" class="sectionHeaderText"></span>
<span class="toggleCollapse" rsf:id="msg=simplepage.clickToCollapse"></span>
</h3>
</a>
<div id="collapsibleContent" class="collapse show">
<div rsf:id="section:" id="section" class="section">
<div rsf:id="column:" class="column">
<div class="editsection">
Expand Down Expand Up @@ -3223,6 +3224,7 @@ <h4><span rsf:id="peer-eval-target-name"></span></h4>
</script>
</div>
</div>
</div>
<!-- end section wrapper -->
</div>
<script>
Expand Down
Loading