Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set versionModel._id to null when creating a copy of the shadow document #14

Closed
wants to merge 1 commit into from
Closed

Set versionModel._id to null when creating a copy of the shadow document #14

wants to merge 1 commit into from

Conversation

sandytrinh
Copy link

Hi there,

I've updated the versionModel._id = null as discussed in #7 and #9

I've ran the provided test cases and performed tests to ensure a shadow document is created for each edit of the original document.

I've tested this in mongoose version 3.8.13

Can you please merge?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 240ceba on flashmedia:master into dbe047a on saintedlama:master.

@sandytrinh
Copy link
Author

Closing this PR as the master this PR uses contains a bug raised in #10

@sandytrinh sandytrinh closed this Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandytrinh @coveralls