devel→master: Changeset for v0.3.4
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [flowplayer.spec] Add Ruben de Smet (rubdos) * [README.md] Add Ruben de Smet (rubdos) * [AboutPage.qml] Add Ruben de Smet (rubdos) * [LICENSE.txt] Add Ruben de Smet (rubdos)
* [README.md] Add Mark Washeim (poetaster) to contributors * [AboutPage.qml] Add Mark Washeim (poetaster) to contributors * [LICENSE.txt] Add Mark Washeim (poetaster) to contributors * [flowplayer.spec] Add poetaster to developers list
* [Feature] add initial addition for cover art if a jpg is found in the directory as tracks are added to the db. also, correct old Generic paths, and test with sailjail. * PR: feedback integrated: 1. alternate logic for applying folder/cover image copy, basename check. 2. remove media indexing sailjail perms, 3. move cache dir creation from migrate to main * [FlowPlayer.cpp] Improve style as suggested by @dcaliste * [datareader.cpp] Improve style as suggested by @dcaliste * [flowplayer.desktop] Omit SailJail sandboxing configuration for now * [datareader.cpp] Improve style as suggested by @dcaliste * Review: remove png processing * Update datareader.cpp remove unused QImage and png matching. * Fix:logic of the || on png * [datareader.cpp] Indention, no `jpg` & `png` for now, iterator reuse Addresses comments dispersed over PR #75's lengthy discussion. * [datareader.cpp] Rectify comment * [datareader.cpp] Improve comments & break long code line in two * [datareader.cpp] Break two more long lines in two * [datareader.cpp] Remove superfluous backslashes "\" * [datareader.cpp] Omit superfluous space character " " * [datareader.cpp] Extend comment * Don't recurse in subdirs when looking for covers. * [datareader.cpp] Insert comment and align with current TS files --------- Co-authored-by: olf <[email protected]> Co-authored-by: Damien Caliste <[email protected]>
100% translated source file: 'translations/flowplayer.ts' on 'de'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
100% translated source file: 'translations/flowplayer.ts' on 'sv'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.