Remove taglib and mytaglib
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Olf0
added a commit
that referenced
this pull request
Dec 5, 2023
* [README.md] Description stub and History * [.gitignore] Add missed space character in comment * [README.md] Enhance table with screenshots * [flowplayer.spec] Revert part of e11649d * [build-on-tags.yml] Fix using the wrong action-branch for SFOS < 4.1.0 (#18) * [README.md] Fix table rendering by inserting ` '`s * [README.md] Optimise table spans, again * [README.md] Large screenshot subtitles * [README.md] Final screenshots-table formatting fix-up … …, hopefully. * [flowplayer.spec] Do first release for years still without `Vendor` set * [README.md] Use relative image links * Update README.md with License link * [README.md] Link issue, fix italicisation. * [README.md] Fix link: https://app.transifex.com/olf/flowplayer-1 * Add missing QImage includes. * Adjust calls for GStreamer 1.0 API. * Remove internal taglib * Use QStandardPaths instead of hardcoded paths. * Adjust some icon sizes * Remove `taglib` and `mytaglib` (#22) * Delete src/taglib directory Obsoleted by PR #19 by @dcaliste * Delete src/mytaglib directory Obsoleted by PR #19 by @dcaliste * Delete lib directory Obsoleted by PR #19 by @dcaliste * Update README.md to recent changes * Update README.md * [README.md] Fix spell'o * [flowplayer.spec] Up `version`-`release` to 0.3.0-rc1 * Update flowplayer.changes for v0.3.0 * Update flowplayer.changes --------- Co-authored-by: Damien Caliste <[email protected]>
|
Thanks @Olf0 , nice investigation on the versions and dates. I agree with your reasoning. |
|
This comment really belongs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoleted by PR #19 by @dcaliste
Note that
taglibwas always installed by default on SailfishOS, presumably CepiPerez included a copy oftaglib(TagLib 1.9.1 - Oct 8, 2013) due to deficits of the pre-installed one.taglibwas updated from1.7.2to1.11.1in SFOS 2.1.3 on 01 November 2017, i.e. long after Cepi ceased to maintain FlowPlayer. The other mentions oftaglibin the changelogs of SailfishOS 2.0.2 and SailfishOS 3.0.2 only denote minor packaging changes.taglibis still at version1.11.1in SFOS 3.2.1.This PR is carried out expecting that
taglib-1.11.1fixes what Cepi was addressing by including an own version (TagLib 1.9.1 - Oct 8, 2013, plus the changes in themytaglibdirectory).