358 Bugfix Broker::processMessageReply #651
Conversation
Before this commit processMessageReply did not work for exceptions with a reccurent id in an other timezone than the dtstart of the master event.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
=========================================
Coverage 98.78% 98.78%
- Complexity 1866 1867 +1
=========================================
Files 71 71
Lines 5249 5253 +4
=========================================
+ Hits 5185 5189 +4
Misses 64 64 ☔ View full report in Codecov by Sentry. |
| // This is a reply to 1 instance of a recurring event. This should | ||
| // automatically create an exception. |
There was a problem hiding this comment.
I don't understand why this comment has "This should automatically create an exception."
The source code now handles this situation.
TZID=Asia/Ho_Chi_Minh:20140725T110000 is the event recurrence of DTSTART;TZID=America/Toronto:20140724T000000 that happens the next day, 20140725.
America/Toronto is UTC-4, Asia/Ho_Chi_Minh is UTC+7. So they are 11 hours apart. 0000 in Toronto is the same time as 1100 in Ho Chi Minh City.
| // This is a reply to 1 instance of a recurring event. This should | ||
| // automatically create an exception. |
There was a problem hiding this comment.
I don't understand why this comment has "This should automatically create an exception."
Similar to my other comment above, America/Toronto is UTC-4. So 0000 in Toronto is the same as 040000Z
I don't expect any exception to happen.
|
Closing in favor of #652 - IMO that is a cleaner solution. |
Before this commit processMessageReply did not work for exceptions with a reccurent id in an other timezone than the dtstart of the master event.
This is a rebased version of PR #360