Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #646 #649

Merged
merged 4 commits into from
May 9, 2024
Merged

fix issue #646 #649

merged 4 commits into from
May 9, 2024

Conversation

JohnRDOrazio
Copy link
Contributor

@JohnRDOrazio JohnRDOrazio commented Apr 23, 2024

add lineIndex and lineString properties to a Property Node

issue #646

@JohnRDOrazio
Copy link
Contributor Author

if this PR is accepted, perhaps documentation could be updated to explain how to access the properties of a node, and warn against simply trying to json_encode the resulting errors...

@JohnRDOrazio
Copy link
Contributor Author

I added a Unit Test that will check for lineIndex and lineString properties when validating defective calendar data.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (f14092f) to head (ec31757).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #649   +/-   ##
=========================================
  Coverage     98.78%   98.78%           
- Complexity     1866     1868    +2     
=========================================
  Files            71       71           
  Lines          5249     5253    +4     
=========================================
+ Hits           5185     5189    +4     
  Misses           64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor

@JohnRDOrazio php-cs-fixer wants some formatting adjusted.
You can:
composer cs-fixer
and commit and push the changes it makes.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this implements error handling features similar to what happens elsewhere (see the PR and issue #646 discussions.

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change!

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@phil-davis phil-davis merged commit 8a2dab4 into sabre-io:master May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants