-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #646 #649
fix issue #646 #649
Conversation
if this PR is accepted, perhaps documentation could be updated to explain how to access the properties of a node, and warn against simply trying to |
I added a Unit Test that will check for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
=========================================
Coverage 98.78% 98.78%
- Complexity 1866 1868 +2
=========================================
Files 71 71
Lines 5249 5253 +4
=========================================
+ Hits 5185 5189 +4
Misses 64 64 ☔ View full report in Codecov by Sentry. |
@JohnRDOrazio php-cs-fixer wants some formatting adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this implements error handling features similar to what happens elsewhere (see the PR and issue #646 discussions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
add
lineIndex
andlineString
properties to aProperty
Nodeissue #646