Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-cs-fixer 3.49 (or some recent minor release) wants to use the
?
(nullable) syntax on optional parameters.That syntax has been supported for quite a while since PHP https://www.php.net/manual/en/migration71.new-features.php
In the cases here, as well as the default value of the parameter being
null
, the?
explicitly allows the caller to pass the valuenull
if they want.And some mentions of type
boolean
change to justbool
- that seems "a good thing" because ofhttps://www.php.net/manual/en/language.types.declarations.php
"Warning
Name aliases for scalar types (bool, int, float, string) are not supported. Instead, they are treated as class or interface names. For example, using boolean as a type declaration will require the value to be an instanceof the class or interface boolean, rather than of type bool"
php-cs-fixer has only found things to fix in the PHP doc for this
bool
thing, so no actual code effect to think about.These seem reasonable, I don't see how it can break any existing usage.