Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass OPTION_FORGIVING to VObject Reader #1563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solracsf
Copy link

@solracsf solracsf commented Oct 5, 2024

See nextcloud/3rdparty#902

By passing the "forgiving" option, some ICS files that would otherwise be rejected, can be successfully imported.

Specifically, Outlook for Mac generates ICS files with an invalid key X-ENTOURAGE_UUID (underscore is invalid). By being forgiving, this key is ignored instead of rejected and I think a majority of calendar invitations from that client can now be processed successfully for NextCloud users. See issues nextcloud/server#16679 and nextcloud/server#17915 for more context.

I haven't seen other calls to VObject\Reader::read or VObject\Reader::readJson outside of validateICalendar where the same option should be passed, but it's possible I missed something.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (a9d0a90) to head (4b8268b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1563      +/-   ##
============================================
- Coverage     97.24%   97.23%   -0.01%     
- Complexity     2834     2836       +2     
============================================
  Files           175      175              
  Lines          8843     9028     +185     
============================================
+ Hits           8599     8778     +179     
- Misses          244      250       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor

@solracsf can you add some unit test case(s) that demonstrate things that now pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants