Handle 404 in CardDAV multi get - refs #829 #1503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1503 +/- ##
============================================
- Coverage 97.32% 97.32% -0.01%
- Complexity 2833 2841 +8
============================================
Files 175 175
Lines 9425 9443 +18
============================================
+ Hits 9173 9190 +17
- Misses 252 253 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
DeepDiver1975
force-pushed
the
DeepDiver1975-multiget-404-2
branch
from
915a39a
to
e61f0a0
Compare
DeepDiver1975
force-pushed
the
DeepDiver1975-multiget-404-2
branch
from
e61f0a0
to
3c39275
Compare
|
rebased - @clxmstaab @phil-davis mind a review? THX |
staabm
approved these changes
Sep 17, 2024
| @@ -124,7 +124,7 @@ public function xmlSerialize(Writer $writer): void | |||
| $writer->writeElement('{DAV:}href', $writer->contextUri.\Sabre\HTTP\encodePath($this->getHref())); | |||
|
|
|||
| $empty = true; | |||
| $httpStatus = $this->getHTTPStatus(); | |||
There was a problem hiding this comment.
looks like we should raise the phpstan level to catch such things :)
(separate PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased #904