Allow subnet to be specified for broadcast #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
reviewed
Mar 12, 2021
rytilahti
reviewed
Mar 25, 2021
| @@ -90,18 +90,22 @@ def send_handshake(self, *, retry_count=3) -> Message: | |||
| return m | |||
|
|
|||
| @staticmethod | |||
| def discover(addr: str = None, timeout: int = 5) -> Any: | |||
| def discover(addr: str = None, is_broadcast: bool = True, timeout: int = 5) -> Any: | |||
There was a problem hiding this comment.
Suggested change
| def discover(addr: str = None, is_broadcast: bool = True, timeout: int = 5) -> Any: | |
| def discover(addr: str = None, timeout: int = 5, *, is_broadcast: bool = True) -> Any: |
Let's move the is_broadcast to be the last parameter, and make it kwarg-only for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address issue #584 - discover doesn't work on Windows unless you specify the correct interface's subnet.
Usage:
Closes #584