Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location slides and header scroller #6

Draft
wants to merge 75 commits into
base: main
Choose a base branch
from
Draft

Add location slides and header scroller #6

wants to merge 75 commits into from

Conversation

ryand56
Copy link
Owner

@ryand56 ryand56 commented Nov 2, 2022

Closes #1

@ryand56 ryand56 added the enhancement Contains a new feature or request label Nov 2, 2022
@ryand56 ryand56 self-assigned this Nov 2, 2022
@ryand56 ryand56 force-pushed the location-slides branch 2 times, most recently from 21c48eb to ebc4da0 Compare November 5, 2022 00:52
@ryand56 ryand56 added the stale label Nov 12, 2022
@ryand56
Copy link
Owner Author

ryand56 commented Nov 12, 2022

Marked stale because I'm too lazy at the moment to work on this. I will continue on this in the next few days or so.

@ryand56 ryand56 removed the stale label Nov 14, 2022
@ryand56
Copy link
Owner Author

ryand56 commented Nov 14, 2022 •
edited
Loading

https://github.com/elementemerald/weatherscan-rewritten/blob/296559547741c852d0222a48a433c3cde1a77c7c/components/Slides/Containers/Headers/SlideHeaderScroll.tsx#L69
Seems like there is an issue with this line matching locations, working on a fix.

@ryand56 ryand56 marked this pull request as ready for review January 31, 2023 21:53
@ryand56 ryand56 marked this pull request as draft February 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryand56 ryand56

Labels
enhancement Contains a new feature or request
Projects
Weatherscan Rewritten
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom city scroller and slides transition
1 participant
@ryand56