Allow tref to pass through encode/2 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydog187
added a commit
to tv-labs/lua
that referenced
this pull request
Sep 27, 2024
Found a bug in Luerl, see rvirding/luerl#184
davydog187
force-pushed
the
table-ref-encoding
branch
from
c530198
to
2a45cf1
Compare
There are times when a `tref` may be passed to Erlang/Elixir, and then we want to return it as-is (or modified) to the emulator. Currently, this will fail when Luerl tries to re-encode the value. Instead, we should just pass through these values as is
davydog187
force-pushed
the
table-ref-encoding
branch
from
2a45cf1
to
e501ea4
Compare
davydog187
added a commit
to tv-labs/lua
that referenced
this pull request
Oct 3, 2024
Before, a `deflua` function couldn't get a tref value and then return it as is. This was fixed in rvirding/luerl#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times when a
trefmay be passed to Erlang/Elixir, and then we want to return it as-is (or modified) to the emulator. Currently, this will fail when Luerl tries to re-encode the value.Instead, we should just pass through these values as is