Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect fixed version for may_queue #2106

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

VorpalBlade
Copy link
Contributor

@VorpalBlade VorpalBlade commented Oct 25, 2024

According to Xudong-Huang/may#88, this was fixed in 0.3.19, but that refers to the main "may" crate. The correct version for the "may_queue" sub crate is 0.1.8 (based on manual checking the bounds for the affected type on docs.rs)

My bad in the previous PR (#2105) for trusting the number written in the relevant bug report.

According to Xudong-Huang/may#88, this was fixed in 0.3.19,
but that refers to the main "may" crate. The correct version for the "may_queue" sub crate
is 0.1.8 (based on manual checking the bounds for the affected type on docs.rs)
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Maybe we need to be validating these versions programatically...

@alex alex merged commit c586bd6 into rustsec:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants