Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proj: remove Makefile.Windows #396

Merged
merged 1 commit into from
Mar 28, 2024
Merged

proj: remove Makefile.Windows #396

merged 1 commit into from
Mar 28, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Mar 11, 2024

Note to reviewers: This builds on #395 - new commits starting at 542c0d6

CMake is the recommended way to build rustls-ffi for Windows platforms. This commit removes the manually curated Makefile specific to Windows to reduce maintenance burden. See additional discussion in #390

@cpu
Copy link
Member Author

cpu commented Mar 11, 2024

Windows Expected — Waiting for status to be reported

This is a stale ref to the removed Makefile.Windows CI task and will need fixing in the branch protection rules.

@cpu cpu self-assigned this Mar 18, 2024
CMake is the recommended way to build rustls-ffi for Windows platforms.
This commit removes the manually curated Makefile specific to Windows to
reduce maintenance burden.
@cpu cpu requested a review from jsha March 28, 2024 19:08
@cpu cpu merged commit c5b0eb1 into rustls:main Mar 28, 2024
21 checks passed
@cpu cpu deleted the cpu-rm-win-makefile branch March 28, 2024 21:25
@cpu
Copy link
Member Author

cpu commented Mar 28, 2024

This is a stale ref to the removed Makefile.Windows CI task and will need fixing in the branch protection rules.

I administratively merged this and updated the branch protection rules to remove the deleted task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants