Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add const try_from_str constructor to DnsName type. #68

Closed
wants to merge 1 commit into from
Closed

feat: add const try_from_str constructor to DnsName type. #68

wants to merge 1 commit into from

Conversation

DSharifi
Copy link
Contributor

Add a const DnsName::from_str method to create DnsName in a const setting.

validate() is refactored to use while loop instead of for loop as for loops are non const.

@DSharifi DSharifi marked this pull request as ready for review January 24, 2025 16:23
@DSharifi DSharifi mentioned this pull request Jan 24, 2025
Closed
cpu
cpu approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Seems reasonable to me!

Would you mind writing a commit message? It could be as simple as the PR description.

@DSharifi
Copy link
Contributor Author

DSharifi commented Jan 24, 2025 •
edited
Loading

Thanks for the quick review!

I amended the commit message now to the PR title.

djc
djc reviewed Jan 24, 2025
View reviewed changes
src/server_name.rs Outdated Show resolved Hide resolved
src/server_name.rs Outdated Show resolved Hide resolved
@djc
Copy link
Member

djc commented Jan 24, 2025

Please squash all your changes into a single commit.

@DSharifi DSharifi closed this Jan 24, 2025
@DSharifi DSharifi mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc left review comments

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DSharifi @djc @cpu