Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: move to axum #42

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

refactor!: move to axum #42

wants to merge 58 commits into from

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Jan 22, 2024 •
edited
Loading

Fixes #2
Fixes #23

TODO:

  • Fix error handling
  • Check unit/integration tests

@simonsan simonsan added A-meta Area: Project wide C-refactor Category: Refactoring of already existing code labels Jan 22, 2024
@simonsan simonsan mentioned this pull request Jan 22, 2024
Open
simonsan and others added 24 commits January 23, 2024 08:29
@simonsan
refactor: begin refactor to axum
4b9c4c4 
Signed-off-by: simonsan <[email protected]>
@simonsan
imports
bedf13c 
Signed-off-by: simonsan <[email protected]>
@simonsan
tracing::debug
7c8bf7f 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor I
12da923 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor II
134b6db 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor III
47b3eb4 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor IV
04ec935 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor V
7c106e8 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor VI
747572a 
Signed-off-by: simonsan <[email protected]>
@simonsan
use pathbuf
71cb856 
Signed-off-by: simonsan <[email protected]>
@simonsan
handle errors better
d41f38f 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix some errors
8f51e4e 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix some errors
0d73eeb 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix path doesn't live long enough
e63a324 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix some errors III
4598058 
Signed-off-by: simonsan <[email protected]>
@simonsan
async stream body to file?
7a04566 
Signed-off-by: simonsan <[email protected]>
@simonsan
add todo
7acd328 
Signed-off-by: simonsan <[email protected]>
@simonsan
remove outdated comment
3b91b40 
Signed-off-by: simonsan <[email protected]>
@simonsan
add todo
4eb18dd 
Signed-off-by: simonsan <[email protected]>
@simonsan
clippy fixes
f3f7bba 
Signed-off-by: simonsan <[email protected]>
@simonsan
remove braces
4a5b708 
Signed-off-by: simonsan <[email protected]>
@simonsan
style: fmt
34ad03d 
Signed-off-by: simonsan <[email protected]>
@simonsan
chore: update to latest axum and apply fixes
d69c1fd 
Signed-off-by: simonsan <[email protected]>
@mundo-68 @simonsan
refactor!: moving to axum (#40)
4771de6
@simonsan simonsan requested a review from aawsome January 23, 2024 10:58
aawsome and others added 21 commits January 23, 2024 23:53
@aawsome
handle paths by axum for files_list
d3e27a3
@aawsome
add handling for missing :path
a4e3bf8
@simonsan
fix: clippy
293be27 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor: Path extraction using Axum
6a1d193 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix: cleanup and borrowing/coercion
287040d 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor(error): more error handling stuff
2088ac7 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix(tests): change route in tests to adapt to path extraction
3d6eb52 
Signed-off-by: simonsan <[email protected]>
@simonsan
tests: cleanup
3077680 
Signed-off-by: simonsan <[email protected]>
@simonsan
WIP: use option
f9807e0 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor: more optional for name
5c94f80 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor: add missing async
4a1e73e 
Signed-off-by: simonsan <[email protected]>
@simonsan
tests: consolidate test names
36fd0ec 
Signed-off-by: simonsan <[email protected]>
@simonsan
refactor: use typed_paths
34fbb1e 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix: cleanup tpe explicit some
dc00979 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix: possible typo?
76ce24b 
Signed-off-by: simonsan <[email protected]>
@simonsan
docs(testing): few corrections
1bf0041 
Signed-off-by: simonsan <[email protected]>
@simonsan
testing: cleanup more from testing
e27fe79 
Signed-off-by: simonsan <[email protected]>
@simonsan
style: fmt
470d999 
Signed-off-by: simonsan <[email protected]>
@mundo-68
fixed repository and file_exchange handlers (#43)
9e7c2c4
@simonsan
fix: few fixes from review
78ab5a7 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix: test_add_delete_config_passes
f72629e 
Signed-off-by: simonsan <[email protected]>
@simonsan
Copy link
Contributor Author

It may make sense to factor out the tests and merge them first, when they run through also with the old code. Or make them run with the old code.

@simonsan
Copy link
Contributor Author

When merging this PR:

  • deactivate the nightly builds for the time being, so this version is not being delivered until stabilized

  • create a note in the Readme, that this version is currently unstable and should not be used outside a development context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aawsome aawsome Awaiting requested review from aawsome

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-meta Area: Project wide C-refactor Category: Refactoring of already existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactivate audit workflow, when refactored to axum Replace tide with axum
3 participants
@simonsan @mundo-68 @aawsome