Replace cargo-kcov with llvm-cov #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-kcov is no longer working as of rust toolchain version 1.71.0, as it can no longer discover test executables. This is due to cargo changing its verbose stdout printing to include the qualified path to rustc, which causes cargo-kcov's string matching to fail. See also kennytm/cargo-kcov#54 cargo-kcov has had its last commit in 2019, so replace it with cargo-llvm-cov, which is actively maintained, and written for rust. Signed-off-by: Patrick Roy <[email protected]>
roypat
requested review from
andreeaflorescu,
gsserge,
lauralt,
stefano-garzarella,
stsquad and
JonathanWoollett-Light
as code owners
JonathanWoollett-Light
approved these changes
Aug 30, 2023
stefano-garzarella
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-kcov is no longer working as of rust toolchain version 1.71.0, as it can no longer discover test executables. This is due to cargo changing its verbose stdout printing to include the qualified path to rustc, which causes cargo-kcov's string matching to fail.
See also kennytm/cargo-kcov#54
cargo-kcov has had its last commit in 2019, so replace it with cargo-llvm-cov, which is actively maintained, and written for rust.
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.