Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing_debug_implementations #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust-vmm-ci
1 change: 1 addition & 0 deletions src/configurator/aarch64/fdt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ impl From<Error> for BootConfiguratorError {
}

/// Boot configurator for device tree.
#[derive(Debug)]
pub struct FdtBootConfigurator {}

impl BootConfigurator for FdtBootConfigurator {
Expand Down
2 changes: 1 addition & 1 deletion src/configurator/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ pub trait BootConfigurator {
}

/// Boot parameters to be written in guest memory.
#[derive(Clone)]
#[derive(Debug, Clone)]
pub struct BootParams {
/// "Header section", always written in guest memory irrespective of boot protocol.
pub header: Vec<u8>,
Expand Down
1 change: 1 addition & 0 deletions src/configurator/x86_64/linux.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ use crate::configurator::{BootConfigurator, BootParams, Error as BootConfigurato
use std::fmt;

/// Boot configurator for the Linux boot protocol.
#[derive(Debug)]
pub struct LinuxBootConfigurator {}

/// Errors specific to the Linux boot protocol configuration.
Expand Down
1 change: 1 addition & 0 deletions src/configurator/x86_64/pvh.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ use crate::loader_gen::start_info::{hvm_memmap_table_entry, hvm_modlist_entry, h
use std::fmt;

/// Boot configurator for the PVH boot protocol.
#[derive(Debug)]
pub struct PvhBootConfigurator {}

/// Errors specific to the PVH boot protocol configuration.
Expand Down
4 changes: 2 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//
// SPDX-License-Identifier: Apache-2.0 AND BSD-3-Clause

#![deny(missing_docs)]
#![deny(missing_docs, missing_debug_implementations)]

//! A Linux kernel image loading crate.
//!
Expand Down Expand Up @@ -101,7 +101,7 @@ pub mod cmdline;
pub mod configurator;
pub mod loader;

#[allow(clippy::undocumented_unsafe_blocks)]
#[allow(clippy::undocumented_unsafe_blocks, missing_debug_implementations)]
#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
mod loader_gen;
#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
Expand Down
1 change: 1 addition & 0 deletions src/loader/aarch64/pe/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ use vm_memory::{Address, ByteValued, Bytes, GuestAddress, GuestMemory, GuestUsiz
use super::super::{Error as KernelLoaderError, KernelLoader, KernelLoaderResult, Result};

/// ARM64 Image (PE) format support
#[derive(Debug)]
pub struct PE;

// SAFETY: The layout of the structure is fixed and can be initialized by
Expand Down
1 change: 1 addition & 0 deletions src/loader/x86_64/bzimage/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ impl fmt::Display for Error {
impl std::error::Error for Error {}

/// Big zImage (bzImage) kernel image support.
#[derive(Debug)]
pub struct BzImage;

impl KernelLoader for BzImage {
Expand Down
1 change: 1 addition & 0 deletions src/loader/x86_64/elf/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ impl fmt::Display for PvhBootCapability {
}

/// Raw ELF (a.k.a. vmlinux) kernel image support.
#[derive(Debug)]
pub struct Elf;

impl Elf {
Expand Down