Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tinyweb to README.md #1885

Merged
merged 5 commits into from
Jan 18, 2025
Merged

Add tinyweb to README.md #1885

merged 5 commits into from
Jan 18, 2025

Conversation

LiveDuo
Copy link
Contributor

@LiveDuo LiveDuo commented Jan 15, 2025

No description provided.

@palfrey
Copy link
Collaborator

palfrey commented Jan 15, 2025

In order to attempt to be as fair as we can with the process regarding additions of new projects we're using external popularity metrics to guide this. Our current standards are at least one of: a minimum of 50 stars on Github; 2000 downloads for projects with published crates; or equivalent values in other areas (e.g. downloads in other places, star-type popularity in other repositories).

Unfortunately the project you've submitted doesn't reach any of these thresholds. If you think that we've miscounted or there is another public metric that you think we should take into account, then please re-open this PR and detail where else we should be looking.

@palfrey palfrey closed this Jan 15, 2025
@LiveDuo
Copy link
Contributor Author

LiveDuo commented Jan 15, 2025

@palfrey Thanks for clarifying.

The project was launched two days ago and if the rate that is growing right now is any indication 50 starts should come relatively soon.

The community has taken the efford well so far https://www.reddit.com/r/rust/comments/1i0hcrt/comment/m6z8u8h/ but I'm not planning to published the project on crates.io. What would be the other metrics so I reopen only when the required criteria are met?

@palfrey
Copy link
Collaborator

palfrey commented Jan 15, 2025

There aren't any other specific metrics, but if you've got anything else with a specific number on it we can look at those.

@LiveDuo
Copy link
Contributor Author

LiveDuo commented Jan 15, 2025

There aren't any other specific metrics, but if you've got anything else with a specific number on it we can look at those.

I will wait unitl 100 starts or so and see then if there's anything I can share. Thanks

@palfrey
Copy link
Collaborator

palfrey commented Jan 15, 2025

There aren't any other specific metrics, but if you've got anything else with a specific number on it we can look at those.

I will wait unitl 100 starts or so and see then if there's anything I can share. Thanks

Note we only need one of the listed metrics, so 50 stars would be enough :)

@LiveDuo
Copy link
Contributor Author

LiveDuo commented Jan 16, 2025

There aren't any other specific metrics, but if you've got anything else with a specific number on it we can look at those.

I will wait unitl 100 starts or so and see then if there's anything I can share. Thanks

Note we only need one of the listed metrics, so 50 stars would be enough :)

If that's the case, the project should now meet the requirements! It passed 50 stars today. I cannot reopen the PR myself, should I create another one?

@palfrey palfrey reopened this Jan 16, 2025
@LiveDuo
Copy link
Contributor Author

LiveDuo commented Jan 17, 2025

Thanks for reopening. The CI fails with:

"tinyweb — A minimal Rust web framework for wasm in 800 lines of code" uses a '—' hyphen, not the '-' hyphen and we enforce the use of the latter one

I tried to git clone and run the CI locally to make sure it works but I get:

thread 'main' panicked at src/main.rs:214:21:
"{\"message\":\"API rate limit exceeded for $IP_ADDRESS. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)\",\"documentation_url\":\"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting\"}\n"

So I just blindly updated the text (just by copyng the hyphen from the error message) hoping it will work.

@palfrey
Copy link
Collaborator

palfrey commented Jan 17, 2025

I tried to git clone and run the CI locally to make sure it works but I get:

thread 'main' panicked at src/main.rs:214:21:
"{\"message\":\"API rate limit exceeded for $IP_ADDRESS. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)\",\"documentation_url\":\"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting\"}\n"

Yeah. We cache the results we're able to get, so what happens is once the rate limit has recovered you can re-run things several times and eventually get all the things :) Also if you set the env variables USERNAME_FOR_GITHUB and TOKEN_FOR_GITHUB to your github username and a PAT token it'll run for a bit larger batch each time.

@palfrey
Copy link
Collaborator

palfrey commented Jan 17, 2025

This entry is fine now, but the build is failing because there's an issue in another entry as it's also failing on main. See https://github.com/rust-unofficial/awesome-rust/actions/runs/12820041279/job/35748902348 and I'll get to that in the next couple of days.

@palfrey palfrey enabled auto-merge January 18, 2025 11:43
@palfrey palfrey merged commit bda32ed into rust-unofficial:main Jan 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants