Milestone cargo PRs. #1751
Merged
Milestone cargo PRs. #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a step to the milestone trigger on rust-lang/rust to also milestone PRs in the cargo repo when the cargo submodule is updated. I have been manually running a script to do this for a few years, and I would like to stop needing to run it manually.
In terms of reviewing, the changes are roughly:
Issue::set_milestonecode to separateGithubClient::get_or_create_milestoneandGithubClient::set_milestoneso that the milestones can be more easily and efficiently set in a batch (without needing anIssueobject, and without querying for each PR).milestone_prsnow checks if the PR touchessrc/tools/cargo, and if it does, callsmilestone_cargoto milestone every PR in the submodule update.Repository::commits_in_rangemethod for fetching commits within a SHA range. This is necessary to determine which PR each commit comes from.I've done a little bit of testing, and it seems to work for master and beta updates, rollups, etc. However, I didn't do a full end-to-end test, since that would require receiving events from rust-lang/rust which I cannot do.