Upgrade cynic to v3 #1743
Merged
Upgrade cynic to v3 #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I released v3 of cynic a while back, figured I might as well contribute an upgrade in triagebot. The main changes that'll have an impact here are: 1. I've added the ability to pre parse schems in `build.rs`, which is now in use here. This makes a big difference to the compile time of crates using large schemas (such as the GitHub schema triagebot uses). 2. The `schema_for_derives` attribute macro is no longer required so I've got rid of that. 3. Query variables can now be references so I've made that change in the places where it made sense.
apiraino
reviewed
Nov 6, 2023
obmarg
commented
Nov 6, 2023
obmarg
commented
Nov 6, 2023
Co-authored-by: apiraino <[email protected]>
ehuss
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I released v3 of cynic a while back, this pulls that release into triagebot.
The main changes that'll have an impact here are:
build.rswhich is now in use here. This makes a big difference to the compile time of crates using large schemas (such as the GitHub schema triagebot uses).schema_for_derivesattribute macro is no longer required so I've got rid of that.