Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage expectation w/r/t PR response times #1737

Closed
wants to merge 1 commit into from
Closed

Manage expectation w/r/t PR response times #1737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/handlers/assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,14 @@ mod tests {
mod tests_from_diff;
}

const RESPONSE_TIME_EXPECTATIONS: &str = "Note that Rust project members are predominantly \
volunteers with their own priorities and lives beyond Rust. It may take several weeks before \
they get back to you. Please be patient.";

const NEW_USER_WELCOME_MESSAGE: &str = "Thanks for the pull request, and welcome! \
The Rust team is excited to review your changes, and you should hear from {who} soon.";
The Rust team is excited to review your changes, and you should hear from {who} soon.

" + RESPONSE_TIME_EXPECTATIONS;

const CONTRIBUTION_MESSAGE: &str = "Please see [the contribution \
instructions]({contributing_url}) for more information. Namely, in order to ensure the \
Expand All @@ -56,7 +62,9 @@ const WELCOME_WITHOUT_REVIEWER: &str = "@Mark-Simulacrum (NB. this repo may be m

const RETURNING_USER_WELCOME_MESSAGE: &str = "r? @{assignee}

({bot} has picked a reviewer for you, use r? to override)";
({bot} has picked a reviewer for you, use r? to override)

" + RESPONSE_TIME_EXPECTATIONS;

const RETURNING_USER_WELCOME_MESSAGE_NO_REVIEWER: &str =
"@{author}: no appropriate reviewer found, use r? to override";
Expand Down