Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dummy function added in #1592 #1621

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Remove the dummy function added in #1592 #1621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions crates/core_arch/src/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,3 @@ mod nvptx;
#[cfg(any(target_arch = "loongarch64", doc))]
#[doc(cfg(target_arch = "loongarch64"))]
mod loongarch64;

// TODO: remove after merge of rustc #126704
#[unstable(feature = "sha512_sm_x86", issue = "126624")]
unsafe fn dummy() {
// This has to be here until PR #126704 gets merged into rustc,
// because otherwise rustc cannot compile because aarch64 also has
// a target feature named sm4, and that is stable. For `doc` env this
// gets compiled also in x86, but in x86 the feature sm4 is unstable
// So we need `feature(sha512_sm_x86)` somewhere, but if we place it without
// any unstable attr, rustc cannot compile stage0, because it doesn't know about
// this feature yet.
}
Loading