Generate constant Neon vectors within a const block #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. |
|
LGTM! Let me know when rust-lang/rust#118171 is merged and the nightly has been bumped so I can merge this. |
|
CI should be fixed, can you rebase? |
|
Oh nevermind, we're still waiting on rust-lang/rust#118171. |
|
☔ The latest upstream changes (presumably 5a748ec) made this pull request unmergeable. Please resolve the merge conflicts. |
GeorgeWort
force-pushed
the
consts
branch
2 times, most recently
from
bb25872
to
d9d6cb8
Compare
|
I have added the use of #[rustc_intrinsic_const_vector_arg] following discussion on rust-lang/rust#118209. |
|
☔ The latest upstream changes (presumably 6d0479d) made this pull request unmergeable. Please resolve the merge conflicts. |
This allows the constant vector to be passed directly to LLVM which fixes a few issues where the LLVM intrinsic expects a constant vector.
formatting remove comma put back square brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the constant vector to be passed directly to LLVM which fixes a few issues where the LLVM intrinsic expects a constant vector.
This relies on rust-lang/rust#118171 to be useful