Fix some minor intrinsic-test issues. #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
jacobbramley
force-pushed
the
dev/arm-test-warnings
branch
from
0d7123e
to
92180b8
Compare
Amanieu
reviewed
Oct 31, 2023
crates/intrinsic-test/src/types.rs
Outdated
| /// This is determistic based on the pass number. | ||
| /// | ||
| /// * `loads`: The number of values that need to be loaded from the argument array | ||
| /// * e.g for argument type uint32x2, loads=2 results in a string representing 4 32-bit values | ||
| /// | ||
| /// Returns a string such as | ||
| /// * `0x1, 0x7F, 0xFF` if `language` is `Language::C` | ||
| /// * `0x1 as _, 0x7F as _, 0xFF as _` if `language` is `Language::Rust` | ||
| /// * `[0x1, 0x7F, 0xFF]` if `language` is `Language::C` |
There was a problem hiding this comment.
Fixed in (force-pushed) 326fe6f.
This fixes "unnecessary `unsafe` block" warnings encountered when building the generated rust_programs. The only pattern that actually required `unsafe` was transmuting bit patterns into floats. This patch uses the safe `from_bits` instead, but because that isn't const, we have to make them local let-bound variables.
- Ensure that C literals don't rely on undefined overflow behaviour. - We don't need to use 'as' casts, so remove them. - We weren't using allow(overflowing_literals), so remove it. - Format FP bit values as hex. This simplifies the test input initialisers in the generated files, making them shorter and easier to debug.
CARGO_PKG_AUTHORS is :-separated. Also add myself to intrinsic-test authors.
This avoids a flood of warnings when testing the armv7-unknown-linux-gnueabihf target. Under this target, we would pass -Ctarget-features=+neon when building intrinsic-test, but it is compiled for the host (and this tool doesn't need Neon even if the host _is_ Armv7). This also sets --target when running the 'hex' example, since that seems more appropriate than always building it for the host.
jacobbramley
force-pushed
the
dev/arm-test-warnings
branch
from
92180b8
to
326fe6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, fix some warnings that flood the console, making it awkward to debug Arm tests.