Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RISC-V Zb intrinsics #1461

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

coastalwhite
Copy link
Contributor

This is the second PR for rust-lang/rust#114544 and a follow-up to #1453.

This PR adds all the instructions for the zb extension. This PR will get force-pushed after #1453 is merged.

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

@Amanieu
Copy link
Member

Amanieu commented Aug 21, 2023

Most of these already exist as plain Rust operations or methods on the integer types. We do not need intrinsics for these.

I would only keep these which don't have a straightforward mapping to plain Rust code:

  • clmul*
  • orc_b.

@bors
Copy link
Contributor

bors commented Aug 31, 2023

☔ The latest upstream changes (presumably f17c175) made this pull request unmergeable. Please resolve the merge conflicts.

@coastalwhite coastalwhite marked this pull request as ready for review September 1, 2023 15:23
@coastalwhite
Copy link
Contributor Author

This is now also done if you are okay with it 😄

@Amanieu Amanieu merged commit 71f58bd into rust-lang:master Sep 1, 2023
26 checks passed
@coastalwhite coastalwhite deleted the riscv-zb-ext-intrinsics branch September 1, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants