Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clearer that guarantees in ABI compatibility are for Rust only #132200

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Mark-Simulacrum
Copy link
Member

cc #132136 (comment) -- it looks like we already had a note that I missed in my initial look here, but this goes further to emphasize the guarantees, including uplifting it to the top of the general documentation.

r? @RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 26, 2024
@RalfJung
Copy link
Member

LGTM, thanks
Cc @rust-lang/opsem for awareness.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 27, 2024

📌 Commit c1a08f9 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…g, r=RalfJung

Make clearer that guarantees in ABI compatibility are for Rust only

cc rust-lang#132136 (comment) -- it looks like we already had a note that I missed in my initial look here, but this goes further to emphasize the guarantees, including uplifting it to the top of the general documentation.

r? `@RalfJung`
@bors
Copy link
Contributor

bors commented Oct 27, 2024

⌛ Testing commit c1a08f9 with merge 5d0b6ab...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-apple-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@jieyouxu
Copy link
Member

Job was cancelled.
@bors r=@RalfJung

@bors

This comment was marked as resolved.

@bors
Copy link
Contributor

bors commented Oct 28, 2024

📌 Commit c1a08f9 has been approved by RalfJung

It is now in the queue for this repository.

@bors

This comment was marked as resolved.

@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Testing commit c1a08f9 with merge 6929a48275547ef2aae72b85b5b5d8e4acbb5067...

@bors
Copy link
Contributor

bors commented Oct 28, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 6929a48 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2024
@bors bors merged commit 6929a48 into rust-lang:master Oct 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6929a48): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.4%, secondary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
-1.8% [-3.0%, -1.0%] 4
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

Results (secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-3.3%, -2.4%] 9
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 783.63s -> 783.592s (-0.00%)
Artifact size: 333.67 MiB -> 333.70 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants