Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the riscv_ext_intrinsics feature for #114544 #114546

Closed

Conversation

coastalwhite
Copy link
Contributor

This PR starts the implementation of #114544.

This feature is needed to remove the feature gate on stdsimd for the RISC-V intrinsics.

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-15 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=coastalwhite
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_00fab0d9-1886-4e8c-946c-5f7703f9e94a
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_GRAPHQL_URL=https://api.github.com/graphql
GITHUB_HEAD_REF=riscv-ext-intrinsics-feature
GITHUB_JOB=pr
GITHUB_PATH=/home/runner/work/_temp/_runner_file_commands/add_path_00fab0d9-1886-4e8c-946c-5f7703f9e94a
GITHUB_REF=refs/pull/114546/merge
GITHUB_REF_NAME=114546/merge
GITHUB_REF_PROTECTED=false
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=d6e2b6781dd9bc4b3dbdea21c9845cda96bd0b88
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_00fab0d9-1886-4e8c-946c-5f7703f9e94a
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_00fab0d9-1886-4e8c-946c-5f7703f9e94a
GITHUB_TRIGGERING_ACTOR=coastalwhite
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/114546/merge
GITHUB_WORKFLOW_SHA=d6e2b6781dd9bc4b3dbdea21c9845cda96bd0b88
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_18_X64=/opt/hostedtoolcache/go/1.18.10/x64
---
...........................................................................

failures:

---- [ui] tests/ui/feature-gates/feature-gate-riscv-ext-intrinsics.rs stdout ----
error: ui test compiled successfully!
status: exit status: 0
status: exit status: 0
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/feature-gate-riscv-ext-intrinsics.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-riscv-ext-intrinsics" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-riscv-ext-intrinsics/auxiliary"
stderr: none




failures:
    [ui] tests/ui/feature-gates/feature-gate-riscv-ext-intrinsics.rs
test result: FAILED. 15248 passed; 1 failed; 138 ignored; 0 measured; 0 filtered out; finished in 133.80s

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
Build completed unsuccessfully in 0:10:53

@coastalwhite
Copy link
Contributor Author

Heya! I am a bit unfamiliar with this process and I cannot find exactly how to do this. I tried following this https://rustc-dev-guide.rust-lang.org/implementing_new_features.html, but this is for language features and not core lib additions.

I am also failing to find another example of people using this process. Is this even needed for a library feature?

@coastalwhite
Copy link
Contributor Author

Closing as this does not seem necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants