Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for unneeded_struct_pattern #14031

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-semenyuk
Copy link
Member

This lint was merged recently #13465 and should go with the next version 1.85.0 https://github.com/rust-lang/rust-clippy/tags

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 19, 2025
@@ -32,7 +32,7 @@ declare_clippy_lint! {
/// None => 0,
/// };
/// ```
#[clippy::version = "1.83.0"]
#[clippy::version = "1.85.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this version be 1.86.0?

Suggested change
#[clippy::version = "1.85.0"]
#[clippy::version = "1.86.0"]

Copy link
Contributor

@lapla-cogito lapla-cogito Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of Clippy at the time this PR was merged (34d109f) seems to be 0.1.86:

version = "0.1.86"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks for pointing. But why we don't have tag for 1.85.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1.85.0 will be added when it become stable.

@alex-semenyuk alex-semenyuk force-pushed the fixVersion_UNNEEDED_STRUCT_PATTERN branch from 0fc719f to 5bd989a Compare January 19, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants